Improve and document hold utility #7474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
reviewed
Nov 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7474 +/- ##
===========================================
+ Coverage 41.55% 82.29% +40.74%
===========================================
Files 326 338 +12
Lines 48522 50851 +2329
===========================================
+ Hits 20163 41848 +21685
+ Misses 28359 9003 -19356 ☔ View full report in Codecov by Sentry. |
hoxbro
reviewed
Nov 8, 2024
Co-authored-by: Simon Høxbro Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
holdutility is likely criminally underused by users simply because we haven't made it very visible. In this PR I did a few things:holdholdpanel.io.modeltopanel.io.document